Make Reaper's backend configurable

k8ssandra · Jul 2, 2024 · fbc32af · fbc32af
1 parent 63ff0fe
commit fbc32af
Show file tree

Hide file tree

Showing 6 changed files with 55 additions and 2 deletions.
diff --git a/apis/reaper/v1alpha1/reaper_types.go b/apis/reaper/v1alpha1/reaper_types.go
@@ -36,6 +36,14 @@ const (
 
 type ReaperTemplate struct {
 
+	// The storage backend to store Reaper's data. Defaults to "cassandra" which causes Reaper to be stateless and store
+	// its state to a Cassandra cluster it repairs (implying there must be one Reaper for each Cassandra cluster).
+	// The "memory" option makes Reaper to store its state locally, allowing a single Reaper to repair several clusters.
+	// +kubebuilder:validation:Enum=cassandra;memory
+	// +kubebuilder:default="cassandra"
+	// +optional
+	StorageType string `json:"storageType,omitempty"`
+
 	// The keyspace to use to store Reaper's state. Will default to "reaper_db" if unspecified. Will be created if it
 	// does not exist, and if this Reaper resource is managed by K8ssandra.
 	// +kubebuilder:default="reaper_db"

diff --git a/charts/k8ssandra-operator/crds/k8ssandra-operator-crds.yaml b/charts/k8ssandra-operator/crds/k8ssandra-operator-crds.yaml
@@ -28672,6 +28672,12 @@ spec:
                             type: string
                         type: object
                     type: object
+                  storageType:
+                    default: cassandra
+                    enum:
+                    - cassandra
+                    - memory
+                    type: string
                   telemetry:
                     description: |-
                       Telemetry defines the desired telemetry integrations to deploy targeting the Reaper pods for all DCs in this cluster
@@ -34560,6 +34566,12 @@ spec:
                   if you know that the schema is already up-to-date, or if you know upfront that QUORUM cannot be achieved (for
                   example, because a DC is down).
                 type: boolean
+              storageType:
+                default: cassandra
+                enum:
+                - cassandra
+                - memory
+                type: string
               telemetry:
                 description: |-
                   Telemetry defines the desired telemetry integrations to deploy targeting the Reaper pods for all DCs in this cluster

diff --git a/config/crd/bases/k8ssandra.io_k8ssandraclusters.yaml b/config/crd/bases/k8ssandra.io_k8ssandraclusters.yaml
@@ -28610,6 +28610,12 @@ spec:
                             type: string
                         type: object
                     type: object
+                  storageType:
+                    default: cassandra
+                    enum:
+                    - cassandra
+                    - memory
+                    type: string
                   telemetry:
                     description: |-
                       Telemetry defines the desired telemetry integrations to deploy targeting the Reaper pods for all DCs in this cluster

diff --git a/config/crd/bases/reaper.k8ssandra.io_reapers.yaml b/config/crd/bases/reaper.k8ssandra.io_reapers.yaml
@@ -2257,6 +2257,12 @@ spec:
                   if you know that the schema is already up-to-date, or if you know upfront that QUORUM cannot be achieved (for
                   example, because a DC is down).
                 type: boolean
+              storageType:
+                default: cassandra
+                enum:
+                - cassandra
+                - memory
+                type: string
               telemetry:
                 description: |-
                   Telemetry defines the desired telemetry integrations to deploy targeting the Reaper pods for all DCs in this cluster

diff --git a/pkg/reaper/deployment.go b/pkg/reaper/deployment.go
@@ -66,7 +66,7 @@ func NewDeployment(reaper *api.Reaper, dc *cassdcapi.CassandraDatacenter, keysto
 	envVars := []corev1.EnvVar{
 		{
 			Name:  "REAPER_STORAGE_TYPE",
-			Value: "cassandra",
+			Value: reaper.Spec.StorageType,
 		},
 		{
 			Name:  "REAPER_ENABLE_DYNAMIC_SEED_LIST",

diff --git a/pkg/reaper/deployment_test.go b/pkg/reaper/deployment_test.go
@@ -487,6 +487,26 @@ func TestSkipSchemaMigration(t *testing.T) {
 	assert.Len(t, deployment.Spec.Template.Spec.InitContainers, 0, "expected pod template to not have any init container")
 }
 
+func TestStorageTypes(t *testing.T) {
+	tests := []struct {
+		name        string
+		storageType string
+	}{
+		{"memory type test", "memory"},
+		{"cassandra type test", "cassandra"},
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			reaper := newTestReaper()
+			reaper.Spec.StorageType = tt.storageType
+			logger := testlogr.NewTestLogger(t)
+			deployment := NewDeployment(reaper, newTestDatacenter(), nil, nil, logger)
+			assert.Len(t, deployment.Spec.Template.Spec.Containers, 1)
+			assert.Equal(t, tt.storageType, deployment.Spec.Template.Spec.Containers[0].Env[0].Value)
+		})
+	}
+}
+
 func newTestReaper() *reaperapi.Reaper {
 	namespace := "service-test"
 	reaperName := "test-reaper"
@@ -502,7 +522,8 @@ func newTestReaper() *reaperapi.Reaper {
 				Namespace: namespace,
 			},
 			ReaperTemplate: reaperapi.ReaperTemplate{
-				Keyspace: "reaper_db",
+				Keyspace:    "reaper_db",
+				StorageType: "cassandra",
 				ResourceMeta: &meta.ResourceMeta{
 					CommonLabels: map[string]string{"common": "everywhere", "override": "commonLevel"},
 					Pods: meta.Tags{