Upgrade k8ssandra-client to fix cassandra.yaml cluster name setting issue when running 4.1+ #1114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssue when running 4.1+
|
No linked issues found. Please add the corresponding issues in the pull request description. |
adejanovski
force-pushed
the
upgrade-k8ssandra-client
branch
from
db4b8e1 to
8b89df8
Compare
Codecov Report
@@ Coverage Diff @@
## release/1.10 #1114 +/- ##
================================================
- Coverage 57.40% 57.39% -0.01%
================================================
Files 100 100
Lines 10193 10193
================================================
- Hits 5851 5850 -1
- Misses 3832 3833 +1
Partials 510 510 |
adejanovski
force-pushed
the
upgrade-k8ssandra-client
branch
from
8b89df8 to
9461592
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
This was
linked to
issues
Nov 13, 2023
burmanm
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Updates the version of k8ssandra-client to v0.2.2 which has a fix for the cluster name issue with Cassandra 4.1+ (the name "Test Cluster" was always used).
Since this was creating issues with Reaper (as reported in #1112), one of the Reaper e2e test was modified to run against Cassandra 4.1.2.
Another tiny bug was fixed here as well: Running
CreateSingleReaperwould run bothCreateSingleReaperandCreateSingleReaperWStargateAndHTTPe2e tests since they begin with the same string. That makesCreateSingleReaperWStargateAndHTTPrun twice since it's also ran separately.Renaming
CreateSingleReapertoCreateSingleReaperNoHttpfixes the issues.Which issue(s) this PR fixes:
Fixes #1110
Fixes #1112
Checklist
Documentation added/updated