Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helm admission hook #1146

Merged
merged 2 commits into from
Dec 20, 2023
Merged

Conversation

burmanm
Copy link
Contributor

@burmanm burmanm commented Dec 19, 2023

What this PR does:
Adds missing AdmissionWebhookConfiguration for the mutating webhook

Which issue(s) this PR fixes:
Fixes #1145

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CHANGELOG.md updated (not required for documentation PRs)
  • CLA Signed: DataStax CLA

@burmanm burmanm requested a review from a team as a code owner December 19, 2023 13:13
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

5.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Merging #1146 (aefb91c) into main (02d4415) will increase coverage by 0.07%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1146      +/-   ##
==========================================
+ Coverage   56.87%   56.95%   +0.07%     
==========================================
  Files         100      100              
  Lines       10300    10309       +9     
==========================================
+ Hits         5858     5871      +13     
+ Misses       3931     3928       -3     
+ Partials      511      510       -1     
Files Coverage Δ
apis/stargate/v1alpha1/stargate_types.go 93.54% <ø> (ø)
pkg/stargate/deployments.go 92.96% <100.00%> (+0.16%) ⬆️

... and 5 files with indirect coverage changes

Copy link
Contributor

@olim7t olim7t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

  • installed two clusters with Kustomize and Helm side-by-side and checked that the configuration is the same
  • created a K8ssandraCluster in the Helm cluster and checked that it started

@adejanovski adejanovski merged commit f251394 into k8ssandra:main Dec 20, 2023
60 of 61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inject secret webhook does not work when installed with Helm
3 participants