Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for readOnlyRootFilesystem (fixes #1402) #1403

Merged
merged 4 commits into from
Sep 12, 2024
Merged

Add support for readOnlyRootFilesystem (fixes #1402) #1403

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f4a5937
Add support for readOnlyRootFilesystem (fixes #1402)
olim7t Sep 10, 2024
5679823
Add tests
adejanovski Sep 11, 2024
001b895
Test readonlyrootfs on a different test which doesn't involve Stargate
adejanovski Sep 11, 2024
13120e5
Fix null pointer issue
olim7t Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/e2e/suite_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -946,7 +946,7 @@ func checkDatacenterReadOnlyRootFS(t *testing.T, ctx context.Context, key framew
dc := &cassdcapi.CassandraDatacenter{}
err := f.Get(ctx, key, dc)
require.NoError(t, err)
require.Equal(t, *dc.Spec.ReadOnlyRootFilesystem, *kc.Spec.Cassandra.ReadOnlyRootFilesystem, "expected datacenter %s to have readOnlyRootFilesystem like it is in the kc", key.Name)
require.Equal(t, ptr.Deref(dc.Spec.ReadOnlyRootFilesystem, false), ptr.Deref(kc.Spec.Cassandra.ReadOnlyRootFilesystem, false), "expected datacenter %s to have readOnlyRootFilesystem like it is in the kc", key.Name)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @olim7t !

}

// createSingleDatacenterClusterWithUpgrade creates a K8ssandraCluster with one CassandraDatacenter
Expand Down
Loading