K8OP-294 Do not try to work out backup status if there are no pods #1462
Conversation
rzvoncek
changed the title
| @@ -103,6 +103,10 @@ func (r *MedusaBackupJobReconciler) Reconcile(ctx context.Context, req ctrl.Requ | |||
| logger.Error(err, "Failed to get datacenter pods") | |||
| return ctrl.Result{}, err | |||
| } | |||
| if len(pods) == 0 { | |||
There was a problem hiding this comment.
This is related to the GetCassandraDatacenterPods..
pods := make([]corev1.Pod, 0)
pods = append(pods, podList.Items...)
Why not simply return podList.Items ? What's the point of making a new slice?
For this method, if there's no pods, why are we requeueing? Do we assume that pods will reappear?
There was a problem hiding this comment.
I don't know why we re-create the slice. It makes sense to not do it. I pushed the commit fixing this.
Yes, we are re-queing because the assumption is the pods will indeed reappear. In the initial ticket, they were replacing nodepools, and they eventually came back. Checking how precisely this works might deserve at least a manual test, and perhaps a follow up ticket.
|
What this PR does: In the MedusaBackupJob controller, we add a check for pods being present. Pods might be absent for temporary reasons, such as nodepool replacement in the linked issue. If we find no pods, we cannot find the related backups (statuses) and crash. Since the pods are likely to come back, we do not stop requeing the reconciliation.
However, if we get the pods, but for some other reason we don't get the backup statuses, something worse happened and we can't recover. So we stop requeing.
Which issue(s) this PR fixes:
Fixes #1454
Checklist