Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new imageConfig #928

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Conversation

burmanm
Copy link
Contributor

@burmanm burmanm commented Mar 27, 2023

What this PR does:
Replaces all the image.Image structs with a string, uses the new cass-operator ImageConfig style. Requires the usage of a cass-operator PR version.

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CHANGELOG.md updated (not required for documentation PRs)
  • CLA Signed: DataStax CLA

@github-actions
Copy link

No linked issues found. Please add the corresponding issues in the pull request description.
Use GitHub automation to close the issue when a PR is merged

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
6.0% 6.0% Duplication

@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Merging #928 (b5f4814) into main (dc852e4) will decrease coverage by 0.15%.
The diff coverage is 84.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #928      +/-   ##
==========================================
- Coverage   57.64%   57.49%   -0.15%     
==========================================
  Files          96       95       -1     
  Lines        9446     9430      -16     
==========================================
- Hits         5445     5422      -23     
- Misses       3542     3547       +5     
- Partials      459      461       +2     
Impacted Files Coverage Δ
apis/k8ssandra/v1alpha1/k8ssandracluster_types.go 36.23% <ø> (ø)
apis/stargate/v1alpha1/stargate_types.go 93.54% <ø> (ø)
pkg/cassandra/datacenter.go 68.15% <ø> (ø)
pkg/medusa/reconcile.go 58.54% <25.00%> (-1.23%) ⬇️
pkg/reaper/deployment.go 93.60% <100.00%> (+0.04%) ⬆️
pkg/stargate/deployments.go 92.91% <100.00%> (+0.07%) ⬆️

... and 1 file with indirect coverage changes

@adejanovski
Copy link
Contributor

@burmanm, the number of merge conflicts and the fact that hasn't moved in 9 months makes me think we should probably close this and revisit later.
wdyt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants