-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for RepairRun REST resource #6
Conversation
// CreateRepairRun creates a new repair run for the given cluster and keyspace. Does not actually trigger the run: | ||
// creating a repair run includes generating the repair segments. Returns the id of the newly-created repair run if | ||
// successful. The owner name can be any string identifying the owner. | ||
CreateRepairRun( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this is a question for @adejanovski. When I create a RepairRun, do I typically want to start it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It depends 😅
So, I'd say not necessarily instantly if you first want to check how many segments you end up with.
@adejanovski @jeffbanks or @jsanda if everything looks good, would you mind giving your approval please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You still have some methods that start with "Get", but I think it's not such a big deal and we can move on with this PR.
We can deal with this in a future refactoring.
Oh you are absolutely right, my bad. I can offer to change the RepairRun-related methods real quick. The I'd suggest to leave the pre-existing methods (GetCluster, etc...) as is and change them later in a follow-up PR. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Thanks for making the change @adutra ! LGTM ✅ |
While API design is being discussed in #5, I'm opening this PR to get the ball rolling. If the design principles change, I will amend it accordingly.
This PR contains a few commits so far:
Commits can be reviewed separately.
┆Issue is synchronized with this Jira Bug by Unito