Skip to content
This repository has been archived by the owner on Aug 2, 2023. It is now read-only.

Disable debug and wrap until calls with a function to provide wait context #113

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

barecode
Copy link

@barecode barecode commented Oct 23, 2019

Proposed fix for #110

As part of this proposed change the set -x flag was removed, effectively disabling debug. I am not sure if that was left in for a reason, or simply missed. The net effect of this change does not surpress the reported errors, but makes the output a bit cleaner for someone to read and follow and provides a wrapper function waitUntil to promote reuse and a central place for changes.

@kaczyns
Copy link
Member

kaczyns commented Oct 24, 2019

@dacleyra Would you please comment on whether the set -x flag was left on intentionally? I suspect that it was.

@dacleyra
Copy link
Contributor

I always write scripts with set -x such that the code & debug is present & understood.

If you want to make it pretty, and deal with behavioral questions after the fact, be my guest.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants