Resumable newblock + notify miners with refreshed blocks #1907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmundnoble
changed the title
thoughtpolice
pushed a commit
that referenced
this pull request
Apr 23, 2024
Github PR: #1907 Change-Id: I16a7fc2fed6c5e09e73cbcb704c81da41b7ffa3b
edmundnoble
force-pushed
the
I16a7fc2fed6c5e09e73cbcb704c81da41b7ffa3b
branch
from
22a8d90 to
28663a3
Compare
thoughtpolice
pushed a commit
that referenced
this pull request
Apr 23, 2024
Github PR: #1907 Change-Id: I16a7fc2fed6c5e09e73cbcb704c81da41b7ffa3b
edmundnoble
force-pushed
the
I16a7fc2fed6c5e09e73cbcb704c81da41b7ffa3b
branch
from
28663a3 to
ddd739d
Compare
edmundnoble
added a commit
that referenced
this pull request
Apr 24, 2024
Github PR: #1907 Change-Id: I16a7fc2fed6c5e09e73cbcb704c81da41b7ffa3b
edmundnoble
force-pushed
the
I16a7fc2fed6c5e09e73cbcb704c81da41b7ffa3b
branch
from
ddd739d to
693dce5
Compare
edmundnoble
added a commit
that referenced
this pull request
Apr 24, 2024
Github PR: #1907 Change-Id: I16a7fc2fed6c5e09e73cbcb704c81da41b7ffa3b
edmundnoble
force-pushed
the
I16a7fc2fed6c5e09e73cbcb704c81da41b7ffa3b
branch
from
693dce5 to
a3422fe
Compare
thoughtpolice
pushed a commit
that referenced
this pull request
Apr 30, 2024
Github PR: #1907 Change-Id: I16a7fc2fed6c5e09e73cbcb704c81da41b7ffa3b
thoughtpolice
pushed a commit
that referenced
this pull request
May 1, 2024
Github PR: #1907 Change-Id: I16a7fc2fed6c5e09e73cbcb704c81da41b7ffa3b
thoughtpolice
pushed a commit
that referenced
this pull request
May 1, 2024
Github PR: #1907 Change-Id: I16a7fc2fed6c5e09e73cbcb704c81da41b7ffa3b
thoughtpolice
pushed a commit
that referenced
this pull request
May 1, 2024
Github PR: #1907 Change-Id: I16a7fc2fed6c5e09e73cbcb704c81da41b7ffa3b
thoughtpolice
pushed a commit
that referenced
this pull request
May 1, 2024
Github PR: #1907 Change-Id: I16a7fc2fed6c5e09e73cbcb704c81da41b7ffa3b
edmundnoble
force-pushed
the
I16a7fc2fed6c5e09e73cbcb704c81da41b7ffa3b
branch
from
a3422fe to
793cac9
Compare
edmundnoble
added a commit
that referenced
this pull request
May 31, 2024
Github PR: #1907 Change-Id: I16a7fc2fed6c5e09e73cbcb704c81da41b7ffa3b
edmundnoble
force-pushed
the
I16a7fc2fed6c5e09e73cbcb704c81da41b7ffa3b
branch
from
793cac9 to
12146fe
Compare
edmundnoble
added a commit
that referenced
this pull request
Jun 14, 2024
Github PR: #1907 Change-Id: I16a7fc2fed6c5e09e73cbcb704c81da41b7ffa3b
edmundnoble
force-pushed
the
I16a7fc2fed6c5e09e73cbcb704c81da41b7ffa3b
branch
from
12146fe to
e18931f
Compare
edmundnoble
added a commit
that referenced
this pull request
Jun 14, 2024
Github PR: #1907 Change-Id: I16a7fc2fed6c5e09e73cbcb704c81da41b7ffa3b
edmundnoble
force-pushed
the
I16a7fc2fed6c5e09e73cbcb704c81da41b7ffa3b
branch
from
e18931f to
0c49a37
Compare
chessai
previously approved these changes
Jun 14, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
edmundnoble
force-pushed
the
I16a7fc2fed6c5e09e73cbcb704c81da41b7ffa3b
branch
from
aab5a98 to
878d64b
Compare
chessai
approved these changes
Jun 17, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
… missing This change makes readFrom return NoHistory when the target parent is missing. Test plan: just our existing tests. Github PR: #1906 Change-Id: I67fd68ed09707c9bff00b0cf7906e026974a2343
This adds a new pact request called ContinueBlock to do this resumption and also adds an option to NewBlock which allows creating empty blocks; as well, the state involved in blocks in progress is encapsulated in a new BlockInProgress type. Test plan is a new test that checks that a block created via NewBlock is identical to a block created via a combination of NewBlock and ContinueBlock. Change-Id: Id0e6f9ac29cbef4e1b029db5be7aee0b80c2f9c8
Makes the mining loop use ContinueBlock to periodically "refresh" blocks, ensuring that they use all of the transactions in the mempool if possible. Test plan will be to put this on a testnet mining node. Change-Id: I25e1ab240e4522d7e56812ff170d0aa849125abe
Github PR: #1907 Change-Id: I16a7fc2fed6c5e09e73cbcb704c81da41b7ffa3b
edmundnoble
force-pushed
the
I16a7fc2fed6c5e09e73cbcb704c81da41b7ffa3b
branch
from
878d64b to
d0bb915
Compare
chessai
previously approved these changes
Jun 17, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Change-Id: Ia9a721c1bbc09ca5612676c6fd16c88750f6de78
edmundnoble
force-pushed
the
I16a7fc2fed6c5e09e73cbcb704c81da41b7ffa3b
branch
from
d0bb915 to
ebc0e09
Compare
chessai
previously approved these changes
Jun 17, 2024
Change-Id: Ib1604f81a9e7f2f8542f28e0c467f417fcd00cc3
… one Change-Id: I7690e0270a51380a556304f4f6acd68bed4afde6
edmundnoble
force-pushed
the
I16a7fc2fed6c5e09e73cbcb704c81da41b7ffa3b
branch
from
ebc0e09 to
3d62826
Compare
chessai
approved these changes
Jun 17, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 17, 2024
Github PR: #1907 Change-Id: I16a7fc2fed6c5e09e73cbcb704c81da41b7ffa3b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://gerrit.aseipp.dev/q/I16a7fc2fed6c5e09e73cbcb704c81da41b7ffa3b