fix: make ctrl-C work for replays (and perhaps more generally) #1973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't understand why this fixes the issue, but it is actually a correct thing to do; this PR just makes sure that we are masked when we fork off the Pact task thread. Change-Id: I98ac853da9efd086be749d388a5eb559f7866af0
edmundnoble
force-pushed
the
push-lyxnrqvylsqv
branch
from
b714bab to
188ecd7
Compare
chessai
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't understand why this fixes the issue, but it is actually a correct thing to do; this PR just makes sure that we are masked when we fork off the Pact task thread.
Change-Id: I98ac853da9efd086be749d388a5eb559f7866af0