optimize RemotePactTest and add new invalid tx test #2084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test is optimized by sharing the TLS cert and HTTP manager between tests. Otherwise the rest of the testing fixture is *not* shared. This PR also adds some tasty steps to a few tests, which makes it clearer what they're spending their time on. There's one extra invalid tx test as well, testing the error from sending to the wrong chain.
rsoeldner
approved these changes
Dec 25, 2024
| @@ -131,6 +131,7 @@ advanceAllChains Fixture{..} = do | |||
| let blockHeights = fmap (view blockHeight) $ latestCut ^. cutMap | |||
| let latestBlockHeight = maximum blockHeights | |||
|
|
|||
| -- TODO: rejig this to do parallel mining. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test is optimized by sharing the TLS cert and HTTP manager between tests. Otherwise the rest of the testing fixture is not shared.
This PR also adds some tasty steps to a few tests, which makes it clearer what they're spending their time on.
There's one extra invalid tx test as well, testing the error from sending to the wrong chain.