Merge pull request #201 from evanshortiss/apicurio-compat-register

fix apicurio compatibility with register function
kafkajs · Apr 5, 2022 · 05a3613 · 05a3613
2 parents 68c9fd5 + 5230831
commit 05a3613
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/src/SchemaRegistry.ts b/src/SchemaRegistry.ts
@@ -112,7 +112,7 @@ export default class SchemaRegistry {
     const helper = helperTypeFromSchemaType(confluentSchema.type)
     const schemaInstance = schemaFromConfluentSchema(confluentSchema, this.options)
     helper.validate(schemaInstance)
-
+    let isFirstTimeRegistration = false
     let subject: ConfluentSubject
     if (userOpts?.subject) {
       subject = {
@@ -134,10 +134,8 @@ export default class SchemaRegistry {
     } catch (error) {
       if (error.status !== 404) {
         throw error
-      }
-
-      if (compatibility) {
-        await this.api.Subject.updateConfig({ subject: subject.name, body: { compatibility } })
+      } else {
+        isFirstTimeRegistration = true
       }
     }
 
@@ -149,6 +147,10 @@ export default class SchemaRegistry {
       },
     })
 
+    if (compatibility && isFirstTimeRegistration) {
+      await this.api.Subject.updateConfig({ subject: subject.name, body: { compatibility } })
+    }
+
     const registeredSchema: RegisteredSchema = response.data()
     this.cache.setLatestRegistryId(subject.name, registeredSchema.id)
     this.cache.setSchema(registeredSchema.id, confluentSchema.type, schemaInstance)