Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace most of the 'kagi search' site: entries with proper names and domains #132

Conversation

thibaultmol
Copy link
Contributor

I'll be honest, I made gpt do all of this (I just quickly checked it didn't change any things it shouldn't have).

I noticed that some of the ones that were changed are no longer using working websites but that's a check for later I guess

@nobodywasishere
Copy link
Member

The d field should stay as kagi.com

@thibaultmol
Copy link
Contributor Author

@NoahAndrews
Copy link
Contributor

NoahAndrews commented Oct 31, 2024

I apologize for my previous comment, I was bothered by what saw as a blind use of AI.

@thibaultmol
Copy link
Contributor Author

thibaultmol commented Oct 31, 2024

no worries, Figured GPT would be better at me at knowing what most of these websites were about (most of them I hadn't heard of till today).
tbf, they seemed right to me (correct like a couple manually) but some of the ones that are corrected in this PR actually just don't exist anymore. .... so i'm not sure if those should then be fully deleted or if those should stay (for people who use redirection systems? i dunno if those would even work then)

@NoahAndrews
Copy link
Contributor

NoahAndrews commented Oct 31, 2024

Yeah, it's a reasonable use (combined with at least a quick verification), I was just thrown by the domains being wrong.

@nobodywasishere
Copy link
Member

nobodywasishere commented Nov 4, 2024

some of the ones that are corrected in this PR actually just don't exist anymore

Feel free to remove any bang that no longer exists (not blocking this PR)

@thibaultmol
Copy link
Contributor Author

just to know the process: I don't know how the ddg bang importing happens.
I'm wondering if I remove them but then kagi does a ddg bang import and re-adds. Is that a possibility?

data/bangs.json Show resolved Hide resolved
@nobodywasishere
Copy link
Member

just to know the process: I don't know how the ddg bang importing happens. I'm wondering if I remove them but then kagi does a ddg bang import and re-adds. Is that a possibility?

There's no automatic DDG bang import, it's just a manual process if they add / change their bangs.

@thibaultmol
Copy link
Contributor Author

I've made the changes

it's just a manual process if they add / change their bangs.

So are you looking at a diff to see what changes? (so you'd also see deleted bangs)

@nobodywasishere
Copy link
Member

So are you looking at a diff to see what changes? (so you'd also see deleted bangs)

Nothing like that currently. It should be feasible to setup an automatic process for this though.

@nobodywasishere nobodywasishere merged commit 16ad999 into kagisearch:main Nov 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants