Support reader more in Firefox #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was a feature request at https://kagifeedback.org/d/2558-summarizer-doesnt-work-when-firefox-reader-mode-is-active This also updates [`rome` to `biome`](https://biomejs.dev/blog/annoucing-biome/) and adds an inline message/solution for [this error when saving a token](https://kagifeedback.org/d/2206-extension-not-logging-in-to-search-in-ubuntu-firefox-private-window/21).
BrunoBernardino
commented
Dec 6, 2023
Comment on lines
+142
to
+145
| if (tab?.url?.startsWith('about:reader?url=')) { | ||
| const newUrl = new URL(tab.url); | ||
| tab.url = newUrl.searchParams.get('url'); | ||
| } |
There was a problem hiding this comment.
This is the reader fix. Basically Firefox provides the URL with that protocol.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a feature request at https://kagifeedback.org/d/2558-summarizer-doesnt-work-when-firefox-reader-mode-is-active
This also updates
rometobiomeand adds an inline message/solution for this error when saving a token.How it looks with the error in Firefox:
And in Chrome the message changes a bit:
kagi_chrome_0.4.3.zip
kagi_firefox_0.4.3.zip