-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ZIO-Kafka version #31
Conversation
this will upgrade kafka client version and remove CVE related to earlier Kafka Clients
Well apparently the interface was changed, so this is no longer a simple single-character PR 🤣 |
…anged in the underlying zio-kafka producer
...a/src/main/scala/io/kaizensolutions/trace4cats/zio/extras/ziokafka/KafkaProducerTracer.scala
Show resolved
Hide resolved
Thanks @yisraelU ! I'll take a look |
you'd think that such an API change would get a minor version update... |
absolutely !! |
Given there are no better ways to compose producers, I don't see a way to improve here... |
You have my thanks and 👍 |
A side note , I'm not sure if the whole nested effect thing is a good interface for a public api for modeling 2 layers of async |
Superseded by #32 |
this will upgrade kafka client version and remove CVE related to earlier Kafka Clients