Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass group version as an argument while creating PVC from volume snapshot #2295

Merged
merged 7 commits into from
Sep 14, 2023

Conversation

kale-amruta
Copy link
Contributor

@kale-amruta kale-amruta commented Aug 30, 2023

Change Overview

APIGroup is currently hardcoded while creating PVC from snapshot. This PR adds an option to pass GroupVersion as an attribute while creating PVC

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • fixes #issue-number

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@github-actions
Copy link
Contributor

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

@kale-amruta kale-amruta force-pushed the VolumesnapshotAPIGroup branch from 9a03a5d to 30aa78c Compare August 30, 2023 14:35
@kale-amruta kale-amruta changed the title Pass GV field as an argument while creating PVC Pass group version as an argument while creating PVC from volume snapshot Aug 30, 2023
@kanisterio kanisterio deleted a comment from viveksinghggits Sep 1, 2023
Copy link
Contributor

@viveksinghggits viveksinghggits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kale-amruta kale-amruta added kueue and removed kueue labels Sep 14, 2023
@mergify mergify bot merged commit e3fadce into master Sep 14, 2023
14 checks passed
@mergify mergify bot deleted the VolumesnapshotAPIGroup branch September 14, 2023 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants