[Don't Review] Add a utility to get container name from podoptions #2319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a utility in `pod.go` to get us container name from podoptions so that we can use this while creating the Pod and while getting the logs from pod and we would get the correct container name that was while creating the pod . In the next PRs this utility will be consumed by rest of the code.
|
Thanks for submitting this pull request 🎉. The team will review it soon and get back to you. If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document. |
viveksinghggits
force-pushed
the
container-from-po
branch
from
fcb9fc6 to
d3da99f
Compare
viveksinghggits
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
This PR adds a utility in
pod.goto get us container name frompodoptionsso that we can use this while creating the Pod and while getting the logs from pod and by doing so we would get the correct container name that was given while creating the pod .In the next PRs this utility will be consumed by rest of the code.
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan