Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking β€œSign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add security context at pod and container level for Kanister operator #3075

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Added the test cases for the security context
Signed-off-by: Anish Bista <anishbista053@gmail.com>
anishbista60 committed Oct 22, 2024
commit 631ea20326d12dcf409f611b83ef863e053a4484
95 changes: 95 additions & 0 deletions pkg/testing/helm/helm_test.go
Original file line number Diff line number Diff line change
@@ -199,6 +199,101 @@ func (h *HelmTestSuite) TestSelectedDeploymentAttrFromKanisterHelmDryRunInstall(
}
}

// Test for Pod and Container-level securityContext in the Helm chart
func (h *HelmTestSuite) TestSecurityContextInHelmChart(c *check.C) {
podSecurity := corev1.PodSecurityContext{
RunAsUser: intPtr(1000),
FSGroup: intPtr(2000),
RunAsNonRoot: boolPtr(true),
}

containerSecurity := corev1.SecurityContext{
RunAsNonRoot: boolPtr(true),
ReadOnlyRootFilesystem: boolPtr(true),
AllowPrivilegeEscalation: boolPtr(false),
Capabilities: &corev1.Capabilities{
Drop: []corev1.Capability{"ALL"},
},
}
var testCases = []struct {
testName string
helmValues map[string]string
expectedPodSecurity *corev1.PodSecurityContext
expectedContainerSecurity *corev1.SecurityContext
}{
{
testName: "Pod and Container security context are set",
helmValues: map[string]string{
"controller.podSecurityContext.runAsUser": "1000",
"controller.podSecurityContext.fsGroup": "2000",
"controller.podSecurityContext.runAsNonRoot": "true",
"controller.containerSecurityContext.capabilities.drop[0]": "ALL",
"controller.containerSecurityContext.runAsNonRoot": "true",
"controller.containerSecurityContext.readOnlyRootFilesystem": "true",
"controller.containerSecurityContext.allowPrivilegeEscalation": "false",
},
expectedPodSecurity: &podSecurity,
expectedContainerSecurity: &containerSecurity,
},
{
testName: "Only Container security context is set",
helmValues: map[string]string{
"controller.containerSecurityContext.capabilities.drop[0]": "ALL",
"controller.containerSecurityContext.runAsNonRoot": "true",
"controller.containerSecurityContext.readOnlyRootFilesystem": "true",
"controller.containerSecurityContext.allowPrivilegeEscalation": "false",
},
expectedPodSecurity: nil,
expectedContainerSecurity: &containerSecurity,
},
{
testName: "Only Pod security context is set",
helmValues: map[string]string{
"controller.podSecurityContext.runAsUser": "1000",
"controller.podSecurityContext.fsGroup": "2000",
"controller.podSecurityContext.runAsNonRoot": "true",
},
expectedPodSecurity: &podSecurity,
expectedContainerSecurity: nil,
},
}

for _, tc := range testCases {
c.Logf("Test name: %s", tc.testName)
defer func() {
h.helmApp.dryRun = false
}()

testApp, err := NewHelmApp(tc.helmValues, kanisterName, "../../../helm/kanister-operator", kanisterName, "", true)
c.Assert(err, check.IsNil)

out, err := testApp.Install()
c.Assert(err, check.IsNil)

resources := helm.ResourcesFromRenderedManifest(out, func(kind helm.K8sObjectType) bool {
return kind == helm.K8sObjectTypeDeployment
})
c.Assert(len(resources), check.Equals, 1)

deployments, err := helm.K8sObjectsFromRenderedResources[*appsv1.Deployment](resources)
c.Assert(err, check.IsNil)

var obj = deployments[h.deploymentName]
c.Assert(obj, check.NotNil)

c.Assert(obj.Spec.Template.Spec.SecurityContext, check.DeepEquals, tc.expectedPodSecurity)
c.Assert(obj.Spec.Template.Spec.Containers[0].SecurityContext, check.DeepEquals, tc.expectedContainerSecurity)
}
}

func boolPtr(b bool) *bool {
return &b
}

func intPtr(i int64) *int64 {
return &i
}

func (h *HelmTestSuite) TearDownSuite(c *check.C) {
c.Log("Uninstalling chart")
err := h.helmApp.Uninstall()