Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING CHANGE: chore(deps): raise grunt peerDependency to 1.1.x, too #286

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

BREAKING CHANGE: chore(deps): raise grunt peerDependency to 1.1.x, too #286

wants to merge 1 commit into from

Conversation

jdforrester
Copy link
Contributor

Note that this is a breaking change (in the name of user security, but still).

johnjbarton
johnjbarton suggested changes Apr 14, 2020
View reviewed changes
Copy link
Contributor

@johnjbarton johnjbarton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please mark as BREAKING CHANGE per https://www.conventionalcommits.org/en/v1.0.0-beta.2/

@jdforrester jdforrester changed the title chore(deps): raise grunt peerDependency to 1.1.x too BREAKING CHANGE: chore(deps): raise grunt peerDependency to 1.1.x, too Apr 14, 2020
@jginsburgn
Copy link
Member

@jdforrester Please fix the commitlint errors:

⧗   input: BREAKING CHANGE: chore(deps): raise grunt peerDependency to 1.1.x too
✖   subject may not be empty [subject-empty]
✖   type may not be empty [type-empty]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnjbarton johnjbarton johnjbarton requested changes

Assignees

@jdforrester jdforrester

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jdforrester @jginsburgn @johnjbarton