-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add case study for unionbigdata in English #566
add case study for unionbigdata in English #566
Conversation
Welcome @pandaoknight! It looks like this is your first PR to karmada-io/website 🎉 |
I noticed the DCO problems, I'll fix it right now with new signed-off-by line. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few concerns about headings
docs/casestudies/unionbigdata.md
Outdated
--- | ||
|
||
## 行业背景 | ||
## 1. Industry Background |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
## 1. Industry Background | |
## Industry Background |
Not very necessary to maintain both ##
and 1.
, which have the same meaning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll remove the numbers.
docs/casestudies/unionbigdata.md
Outdated
|
||
``` | ||
/apis/cluster.karmada.io/v1alpha1/clusters/%s/proxy/api/v1/namespaces/%s/services/%s/proxy/%s | ||
``` | ||
|
||
#### 1、集群监控 | ||
#### 2.2.1. Cluster Monitoring |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#### 2.2.1. Cluster Monitoring | |
#### Cluster Monitoring |
ditto. It need to change more than your expected if you add or remove sections in future
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, I've removed all the numbers. Should I add a new commit or squash them into one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems all right. It has only one commit now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems all right. It has only one commit now.
Thanks for reviewing.
6b4711f
to
d490ce4
Compare
Signed-off-by: PC <[email protected]>
d490ce4
to
b09295d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Thanks @pandaoknight @windsonsea ~
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind documentation
What does this PR do / why do we need it:
This PR adds an English case study titled "UnionBigData's Utilization of Karmada in the Construction of I3Plat at BOE."
Which issue(s) does this PR fix:
Fixes #none
Special notes for your reviewer:
The first two pictures of the architecture have been redrawn in both English and Chinese. The last five pictures remain unchanged. May readers understand them by referring to the context.
I have generated and reviewed the English translation myself. I believe it is understandable, and the terms are correct.