Add checklist for adding new API #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karmada-bot
added
the
kind/documentation
karmada-bot
added
the
size/L
XiShanYongYe-Chang
force-pushed
the
add-checklist-for-new-api
branch
from
c17fc3f
to
ec6649f
Compare
samzong
reviewed
Mar 26, 2024
i18n/zh/docusaurus-plugin-content-docs/current/developers/add-new-api.md
Outdated
Show resolved
Hide resolved
XiShanYongYe-Chang
force-pushed
the
add-checklist-for-new-api
branch
from
ec6649f
to
fce92d6
Compare
windsonsea
reviewed
Apr 11, 2024
Signed-off-by: changzhen <[email protected]>
XiShanYongYe-Chang
force-pushed
the
add-checklist-for-new-api
branch
from
fce92d6
to
635b4f3
Compare
|
@windsonsea Thanks a lot, all comments have been updated. |
|
/cc @RainbowMango |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind documentation
What this PR does / why we need it:
In order to avoid missing items when adding new APIs in the Karmada repo, resulting in extended development time, relevant check items are now added.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: