Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ClusterEviction plugin #588

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Add ClusterEviction plugin #588

merged 1 commit into from
Apr 11, 2024

Conversation

seanlaii
Copy link

@seanlaii seanlaii commented Apr 10, 2024 •
edited
Loading

What type of PR is this?
/kind documentation

What this PR does / why we need it:
Add ClusterEviction plugin description in Developer Guide/Customize the scheduler page.

Which issue(s) this PR fixes:
Fixes karmada-io/karmada#4803

Special notes for your reviewer:

@karmada-bot karmada-bot added the kind/documentation Categorizes issue or PR as related to documentation. label Apr 10, 2024
@karmada-bot
Copy link
Collaborator

Welcome @seanlaii! It looks like this is your first PR to karmada-io/website 🎉

@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 10, 2024
@XiShanYongYe-Chang
Copy link
Member

Related karmada-io/karmada#4803

@XiShanYongYe-Chang
Copy link
Member

Hi @seanlaii, thanks for your contribution!
Please sign off refer to https://github.com/karmada-io/website/pull/588/checks?check_run_id=23640836626

Add ClusterEviction plugin
5dee2d9 
Signed-off-by: wei-chenglai <[email protected]>
Signed-off-by: wei-chenglai <[email protected]>
@seanlaii seanlaii force-pushed the add-clustereviction-plugin-in-customize-scheduler branch from b77123e to 5dee2d9 Compare April 10, 2024 02:22
@seanlaii
Copy link
Author

Hi @seanlaii, thanks for your contribution! Please sign off refer to https://github.com/karmada-io/website/pull/588/checks?check_run_id=23640836626

Thanks for the info! Added.

XiShanYongYe-Chang
XiShanYongYe-Chang reviewed Apr 10, 2024
View reviewed changes
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks~
LGTM

@windsonsea
Copy link
Member

/lgtm for the text

@XiShanYongYe-Chang
Copy link
Member

/cc @RainbowMango

@XiShanYongYe-Chang XiShanYongYe-Chang mentioned this pull request Apr 10, 2024
Closed
RainbowMango
RainbowMango approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 10, 2024
Vacant2333
Vacant2333 approved these changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@Vacant2333 Vacant2333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve thanks

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango, Vacant2333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@XiShanYongYe-Chang
Copy link
Member

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 11, 2024
@karmada-bot karmada-bot merged commit e29c680 into karmada-io:main Apr 11, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XiShanYongYe-Chang XiShanYongYe-Chang XiShanYongYe-Chang left review comments

@Vacant2333 Vacant2333 Vacant2333 approved these changes

@RainbowMango RainbowMango RainbowMango approved these changes

@Poor12 Poor12 Awaiting requested review from Poor12

@windsonsea windsonsea Awaiting requested review from windsonsea

Assignees

@XiShanYongYe-Chang XiShanYongYe-Chang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs: the ClusterEviction plugin was not add to the document
6 participants
@seanlaii @karmada-bot @XiShanYongYe-Chang @windsonsea @RainbowMango @Vacant2333