Migrate extension to node 18

karthiknadig · Sep 6, 2023 · 07b8c5e · 07b8c5e
1 parent a72ebb2
commit 07b8c5e
Show file tree

Hide file tree

Showing 11 changed files with 19 additions and 18 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -9,7 +9,7 @@ on:
       - 'release-*'
 
 env:
-  NODE_VERSION: 16.17.1
+  NODE_VERSION: 18.17.1
   PYTHON_VERSION: '3.10' # YML treats 3.10 the number as 3.1, so quotes around 3.10
   # Force a path with spaces and to test extension works in these scenarios
   # Unicode characters are causing 2.7 failures so skip that for now.

diff --git a/.github/workflows/pr-check.yml b/.github/workflows/pr-check.yml
@@ -8,7 +8,7 @@ on:
       - release*
 
 env:
-  NODE_VERSION: 16.17.1
+  NODE_VERSION: 18.17.1
   PYTHON_VERSION: '3.10' # YML treats 3.10 the number as 3.1, so quotes around 3.10
   MOCHA_REPORTER_JUNIT: true # Use the mocha-multi-reporters and send output to both console (spec) and JUnit (mocha-junit-reporter). Also enables a reporter which exits the process running the tests if it haven't already.
   ARTIFACT_NAME_VSIX: ms-python-insiders-vsix

diff --git a/.nvmrc b/.nvmrc
@@ -1 +1 @@
-v16.17.1
+v18.17.1
diff --git a/build/azure-pipeline.pre-release.yml b/build/azure-pipeline.pre-release.yml
@@ -33,7 +33,7 @@ extends:
     buildSteps:
       - task: NodeTool@0
         inputs:
-          versionSpec: '16.17.1'
+          versionSpec: '18.17.1'
         displayName: Select Node version
 
       - task: UsePythonVersion@0

diff --git a/build/azure-pipeline.stable.yml b/build/azure-pipeline.stable.yml
@@ -28,7 +28,7 @@ extends:
     buildSteps:
       - task: NodeTool@0
         inputs:
-          versionSpec: '16.17.1'
+          versionSpec: '18.17.1'
         displayName: Select Node version
 
       - task: UsePythonVersion@0

diff --git a/build/azure-pipelines/pipeline.yml b/build/azure-pipelines/pipeline.yml
@@ -37,13 +37,13 @@ extends:
         testPlatforms:
           - name: Linux
             nodeVersions:
-              - 16.17.1
+              - 18.17.1
           - name: MacOS
             nodeVersions:
-              - 16.17.1
+              - 18.17.1
           - name: Windows
             nodeVersions:
-              - 16.17.1
+              - 18.17.1
         testSteps:
           - template: /build/azure-pipelines/templates/test-steps.yml@self
             parameters:

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -2154,7 +2154,7 @@
         "@types/md5": "^2.1.32",
         "@types/mocha": "^9.1.0",
         "@types/nock": "^10.0.3",
-        "@types/node": "^16.17.0",
+        "@types/node": "^18.17.1",
         "@types/semver": "^5.5.0",
         "@types/shortid": "^0.0.29",
         "@types/sinon": "^10.0.11",

diff --git a/pythonExtensionApi/package-lock.json b/pythonExtensionApi/package-lock.json
diff --git a/pythonExtensionApi/package.json b/pythonExtensionApi/package.json
@@ -13,7 +13,7 @@
 	"main": "./out/main.js",
 	"types": "./out/main.d.ts",
 	"engines": {
-		"node": ">=16.17.1",
+		"node": ">=18.17.1",
 		"vscode": "^1.78.0"
 	},
     "license": "MIT",

diff --git a/src/test/pythonEnvironments/common/environmentManagers/conda.unit.test.ts b/src/test/pythonEnvironments/common/environmentManagers/conda.unit.test.ts
@@ -156,6 +156,7 @@ suite('Conda and its environments are located correctly', () => {
                         const isFile = typeof dir[name] === 'string';
                         return {
                             name,
+                            path: dir.name?.toString() ?? '',
                             isFile: () => isFile,
                             isDirectory: () => !isFile,
                             isBlockDevice: () => false,