Skip to content

Commit

Permalink
Fix for stack overflow on dispose
Browse files Browse the repository at this point in the history
  • Loading branch information
karthiknadig committed Oct 19, 2023
1 parent 8becc76 commit 0e08a33
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions src/client/tensorBoard/tensorBoardUsageTracker.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,7 @@ export class TensorBoardUsageTracker implements IExtensionSingleActivationServic
@inject(IDisposableRegistry) private disposables: IDisposableRegistry,
@inject(TensorBoardPrompt) private prompt: TensorBoardPrompt,
@inject(TensorboardExperiment) private readonly experiment: TensorboardExperiment,
) {
disposables.push(this);
}
) {}

public dispose(): void {
Disposable.from(...this.disposables).dispose();
Expand Down

0 comments on commit 0e08a33

Please sign in to comment.