Skip to content

Commit

Permalink
Remove debugger (microsoft#22502)
Browse files Browse the repository at this point in the history
- Remove Debugger in the python extension, but only the fact to create a
configuration using 'python' type.
- It is still possible to debug using 'python' type config.
- Add extension "Python Debugger" to extension pack
  • Loading branch information
paulacamargo25 authored Jan 9, 2024
1 parent 84ef0ee commit 3e75937
Show file tree
Hide file tree
Showing 48 changed files with 73 additions and 4,220 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Python extension for Visual Studio Code

A [Visual Studio Code](https://code.visualstudio.com/) [extension](https://marketplace.visualstudio.com/VSCode) with rich support for the [Python language](https://www.python.org/) (for all [actively supported versions](https://devguide.python.org/#status-of-python-branches) of the language: >=3.7), including features such as IntelliSense (Pylance), linting, debugging, code navigation, code formatting, refactoring, variable explorer, test explorer, and more!
A [Visual Studio Code](https://code.visualstudio.com/) [extension](https://marketplace.visualstudio.com/VSCode) with rich support for the [Python language](https://www.python.org/) (for all [actively supported versions](https://devguide.python.org/#status-of-python-branches) of the language: >=3.7), including features such as IntelliSense (Pylance), linting, debugging (Python Debugger), code navigation, code formatting, refactoring, variable explorer, test explorer, and more!

## Support for [vscode.dev](https://vscode.dev/)

Expand Down
2 changes: 1 addition & 1 deletion gulpfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ async function addExtensionPackDependencies() {
// extension dependencies need not be installed during development
const packageJsonContents = await fsExtra.readFile('package.json', 'utf-8');
const packageJson = JSON.parse(packageJsonContents);
packageJson.extensionPack = ['ms-python.vscode-pylance'].concat(
packageJson.extensionPack = ['ms-python.vscode-pylance', 'ms-python.debugpy'].concat(
packageJson.extensionPack ? packageJson.extensionPack : [],
);
// Remove potential duplicates.
Expand Down
22 changes: 1 addition & 21 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "python",
"displayName": "Python",
"description": "IntelliSense (Pylance), Linting, Debugging (multi-threaded, remote), code formatting, refactoring, unit tests, and more.",
"description": "IntelliSense (Pylance), Linting, Debugging (Python Debugger), code formatting, refactoring, unit tests, and more.",
"version": "2023.23.0-dev",
"featureFlags": {
"usingNewInterpreterStorage": true
Expand Down Expand Up @@ -66,7 +66,6 @@
"activationEvents": [
"onDebugInitialConfigurations",
"onLanguage:python",
"onDebugDynamicConfigurations:python",
"onDebugResolve:python",
"workspaceContains:mspythonconfig.json",
"workspaceContains:pyproject.toml",
Expand Down Expand Up @@ -388,12 +387,6 @@
"icon": "$(play)",
"title": "%python.command.python.execInDedicatedTerminal.title%"
},
{
"category": "Python",
"command": "python.debugInTerminal",
"icon": "$(debug-alt)",
"title": "%python.command.python.debugInTerminal.title%"
},
{
"category": "Python",
"command": "python.execSelectionInDjangoShell",
Expand Down Expand Up @@ -1323,13 +1316,6 @@
"title": "%python.command.python.execInDedicatedTerminal.title%",
"when": "false"
},
{
"category": "Python",
"command": "python.debugInTerminal",
"icon": "$(debug-alt)",
"title": "%python.command.python.debugInTerminal.title%",
"when": "!virtualWorkspace && shellExecutionSupported && editorLangId == python"
},
{
"category": "Python",
"command": "python.execSelectionInDjangoShell",
Expand Down Expand Up @@ -1462,12 +1448,6 @@
"group": "navigation@0",
"title": "%python.command.python.execInDedicatedTerminal.title%",
"when": "resourceLangId == python && !isInDiffEditor && !virtualWorkspace && shellExecutionSupported"
},
{
"command": "python.debugInTerminal",
"group": "navigation@1",
"title": "%python.command.python.debugInTerminal.title%",
"when": "resourceLangId == python && !isInDiffEditor && !virtualWorkspace && shellExecutionSupported"
}
],
"explorer/context": [
Expand Down
9 changes: 0 additions & 9 deletions src/client/application/diagnostics/serviceRegistry.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,6 @@ import {
EnvironmentPathVariableDiagnosticsService,
EnvironmentPathVariableDiagnosticsServiceId,
} from './checks/envPathVariable';
import {
InvalidLaunchJsonDebuggerService,
InvalidLaunchJsonDebuggerServiceId,
} from './checks/invalidLaunchJsonDebugger';
import {
InvalidPythonPathInDebuggerService,
InvalidPythonPathInDebuggerServiceId,
Expand Down Expand Up @@ -59,11 +55,6 @@ export function registerTypes(serviceManager: IServiceManager): void {
EnvironmentPathVariableDiagnosticsService,
EnvironmentPathVariableDiagnosticsServiceId,
);
serviceManager.addSingleton<IDiagnosticsService>(
IDiagnosticsService,
InvalidLaunchJsonDebuggerService,
InvalidLaunchJsonDebuggerServiceId,
);
serviceManager.addSingleton<IDiagnosticsService>(
IDiagnosticsService,
InvalidPythonInterpreterService,
Expand Down

This file was deleted.

Loading

0 comments on commit 3e75937

Please sign in to comment.