Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Luciana Abud <[email protected]>
  • Loading branch information
karthiknadig and luabud authored Oct 24, 2023
1 parent c19652b commit 747e95e
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions src/client/logging/settingLogs.ts
Original file line number Diff line number Diff line change
Expand Up @@ -74,10 +74,7 @@ function logOnLegacyLinterSetting(): boolean {
);
} else if (['pydocstyle', 'pylama', 'pycodestyle', 'bandit'].includes(linter)) {
traceError(
`selected linter "${linter}" may be suported extensions like "ruff" which include several linter rules`,
);
traceError(
`Please install extension: https://marketplace.visualstudio.com/items?itemName=charliermarsh.ruff`,
`selected linter "${linter}" may be supported by extensions like "Ruff", which include several linter rules: https://marketplace.visualstudio.com/items?itemName=charliermarsh.ruff`,
);
}
}
Expand All @@ -95,7 +92,7 @@ async function notifyLegacySettings(): Promise<void> {
_isShown = true;
const response = await showErrorMessage(
l10n.t(
'Formatting and Linting features have been moved to separate extensions. Please see the logs for more information.',
'Formatting and linting features have been deprecated from the Python extension. Please install a linter or a formatter extension. Open logs for more information.'
),
Common.showLogs,
);
Expand Down

0 comments on commit 747e95e

Please sign in to comment.