Fix disposing native api

karthiknadig · Jul 22, 2024 · e6701fe · e6701fe
1 parent 1cc490b
commit e6701fe
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/client/pythonEnvironments/index.ts b/src/client/pythonEnvironments/index.ts
@@ -60,7 +60,9 @@ export async function initialize(ext: ExtensionState): Promise<IDiscoveryAPI> {
 
     if (shouldUseNativeLocator()) {
         const finder = getNativePythonFinder();
+        ext.disposables.push(finder);
         const api = createNativeEnvironmentsApi(finder);
+        ext.disposables.push(api);
         registerNewDiscoveryForIOC(
             // These are what get wrapped in the legacy adapter.
             ext.legacyIOC.serviceManager,

diff --git a/src/client/pythonEnvironments/nativeAPI.ts b/src/client/pythonEnvironments/nativeAPI.ts
@@ -334,7 +334,7 @@ class NativePythonEnvironments implements IDiscoveryAPI, Disposable {
     }
 }
 
-export function createNativeEnvironmentsApi(finder: NativePythonFinder): IDiscoveryAPI {
+export function createNativeEnvironmentsApi(finder: NativePythonFinder): IDiscoveryAPI & Disposable {
     const native = new NativePythonEnvironments(finder);
     native.triggerRefresh().ignoreErrors();
     return native;