Skip to content

Commit

Permalink
Fix #234: Correct temp file deletion
Browse files Browse the repository at this point in the history
  • Loading branch information
kartik-v committed Feb 24, 2018
1 parent c75f933 commit 28c6f00
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
6 changes: 4 additions & 2 deletions CHANGE.md
Original file line number Diff line number Diff line change
@@ -1,14 +1,16 @@
Change Log: `yii2-export`
=========================

## version 1.2.9 (_under development_)
## version 1.2.9

**Date:** _work in progress_
**Date:** 24-Feb-2018

- (enh #241): Update Ukranian translations.
- (enh #239): New property `stripHtml` that would strip Html tags.
- (enh #238): New style options for header, box, and cells.
- (enh #236): Autoformat cells via enhanced column configuration style properties.
- (enh #235): Change default export path from `@webroot/runtime/export` to `@app/runtime/export`.
- (enh #234): Correct temp file deletion.
- Refactor and optimize code.
- (enh #232): Replace PHPExcel with updated PHPSpreadsheet library.
- (enh #230): Export HTML content more correctly fixes #168, #126.
Expand Down
4 changes: 2 additions & 2 deletions ExportMenu.php
Original file line number Diff line number Diff line change
Expand Up @@ -2001,10 +2001,10 @@ protected function setOutCellValue($sheet, $index, $value)
*/
protected function cleanup($file, $config)
{
if ($this->raiseEvent('onGenerateFile', [$config['extension'], $this]) !== false) {
if ($this->raiseEvent('onGenerateFile', [$config['extension'], $this]) !== true) {
return;
}
if ($this->deleteAfterSave) {
if ($this->stream || $this->deleteAfterSave) {
@unlink($file);
}
$this->destroyPhpSpreadsheet();
Expand Down

0 comments on commit 28c6f00

Please sign in to comment.