Sampling of the rows of data is not uniform #133
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this function,
k
is a vector of row indexes that represent the sample rows of the data. Currently:k <- round(runif(n, 1, nrow(data)))
However, this does NOT use an equal probability to sample rows. For example:
The first and last rows of the data are only sampled half as often as the other rows of the data.
The proposed fix samples all rows with equal probability: