Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove kassane/cimgui #29

Merged
merged 5 commits into from
Oct 8, 2024
Merged

Remove kassane/cimgui #29

merged 5 commits into from
Oct 8, 2024

Conversation

kassane
Copy link
Owner

@kassane kassane commented Oct 7, 2024

Based on: #27
closes: #26

floooh and others added 4 commits October 7, 2024 10:45
note: this hack avoids adding AddIncludePath because of step priorities when getting WritedFiles - giving a build error.
@kassane kassane requested a review from floooh October 7, 2024 19:47
@kassane kassane self-assigned this Oct 7, 2024
@kassane kassane added the enhancement New feature or request label Oct 7, 2024
@kassane
Copy link
Owner Author

kassane commented Oct 7, 2024

Maybe not an ideal fix. Although, there is no clarification about the real problem with writeFiles.Step.
However, this avoids over engineering to write a customStep.

@floooh
Copy link
Collaborator

floooh commented Oct 8, 2024

Just had a quick look over the PR, but didn't specifically test it. LGTM.

@kassane kassane merged commit cc90ad5 into main Oct 8, 2024
3 checks passed
@kassane kassane deleted the fix-imgui-dep branch October 8, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace kassane/cimgui to cimgui-upstream
2 participants