Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix shdc running - changing filemode #38

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Fix shdc running - changing filemode #38

merged 1 commit into from
Nov 14, 2024

Conversation

kassane
Copy link
Owner

@kassane kassane commented Nov 13, 2024

closes #37

@kassane kassane added the fix fixing bug label Nov 13, 2024
@kassane kassane self-assigned this Nov 13, 2024
@kassane kassane requested a review from floooh November 13, 2024 19:24
@kassane kassane changed the title Fix shdc running Fix shdc running - changing filemode Nov 13, 2024
@kassane
Copy link
Owner Author

kassane commented Nov 14, 2024 •
edited
Loading

@floooh,

I believe this change will already help solve the access problem on MacOS (remember, I'm not an Apple user).
In contrast to my suggestion for the addition of zig build shaders in sokol bindgen. Running it here, will not change the files in the repository, only isolated tests on the target host.

@floooh
Copy link
Collaborator

floooh commented Nov 14, 2024

I'll give it a try on macOS...

@floooh
Copy link
Collaborator

floooh commented Nov 14, 2024

Yep, it 'just works' :)

@kassane kassane merged commit 1197dc6 into main Nov 14, 2024
3 checks passed
@kassane kassane deleted the shaders-exec branch November 14, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floooh floooh floooh approved these changes

Assignees

@kassane kassane

Labels
fix fixing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run zig build shaders
2 participants
@kassane @floooh