Multi-platform kubestr image #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miquella
reviewed
Dec 2, 2024
Dockerfile
Outdated
Comment on lines
1
to
10
| FROM golang:1.22-bookworm AS builder | ||
|
|
||
| ARG TARGETOS | ||
| ARG TARGETARCH | ||
|
|
||
| ENV GO111MODULE=on \ | ||
| CGO_ENABLED=0 \ | ||
| GOOS=linux \ | ||
| GOARCH=amd64 \ | ||
| GOOS=${TARGETOS} \ | ||
| GOARCH=${TARGETARCH} \ | ||
| GOBIN=/dist |
There was a problem hiding this comment.
This means it's using emulation to compile for non-native targets.
Perhaps we should consider using FROM --platform=$BUILDPLATFORM golang:… and changing go install … to go build -o <OUTPUT_BIN> … so that it can use the native build platform and cross-compile (which is much faster and isn't prone to emulation errors).
If so, it may be good to change FROM alpine:… below to include --platform=$TARGETPLATFORM, just to be explicit and clear about which platform is being used where.
bathina2
force-pushed
the
bathina2/multi-platform-image
branch
from
e18c163 to
f07da37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a multi-platform kubestr image.