Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree Types from PVJ, BoP, TF, Betweenlands, NetherEx, ExtraUtilities2 #1

Open
wants to merge 35 commits into
base: master
Choose a base branch
from

Conversation

katubug
Copy link
Owner

@katubug katubug commented Jun 4, 2019

Added the following trees from Project: Vibrant Journey:

  • Pine, Fir, Aspen, Red Maple, Orange Maple, Baobab, Cottonwood, White Cherry Blossom, Pink Cherry Blossom, Willow, Redwood, Mangrove, Juniper, Jacaranda, Palm

Added the following trees from Biomes O' Plenty:

  • Sacred Oak, Ethereal Tree

Added the following plants from Vanilla:

  • Cactuses, Red Mushrooms, Brown Mushrooms

Added the following trees from Twilight Forest (models in primary version did not seem to work):

  • Miner's Tree, Sorting Tree, Tree of Time, Tree of Transformation

Added the following trees from The Betweenlands:

  • Hearthgrove, Nibbletwig, Rubber Tree, Sap Tree, Spirit Tree, Weedwood.

Added the following plants from NetherEx:

  • Elder Brown Mushroom, Elder Red Mushroom (both have small chance of dropping enoki mushrooms)

Added the following trees from Extra Utilities 2:

  • Ferrous Juniper, Dead Ferrous Juniper

Added the following trees from Project: Vibrant Journey:
- Pine, Fir, Aspen, Red Maple, Orange Maple, Baobab, Cottonwood, White Cherry Blossom, Pink Cherry Blossom, Willow, Redwood, Mangrove, Juniper, Jacaranda, Palm

Added the following trees from Biomes O' Plenty:
- Sacred Oak, Ethereal Tree

Added the following plants from Vanilla:
- Cactuses, Red Mushrooms, Brown Mushrooms

Added the following trees from Twilight Forest (models in primary version did not seem to work):
- Miner's Tree, Sorting Tree, Tree of Time, Tree of Transformation

Added the following trees from The Betweenlands:
- Hearthgrove, Nibbletwig, Rubber Tree, Sap Tree, Spirit Tree, Weedwood.

Added the following plants from NetherEx:
- Elder Brown Mushroom, Elder Red Mushroom (both have small chance of dropping enoki mushrooms)

Added the following trees from Extra Utilities 2:
- Ferrous Juniper, Dead Ferrous Juniper
@katubug katubug changed the title Add files via upload Tree Types from PVJ, BoP, TF, Betweenlands, NetherEx, ExtraUtilities2 Jun 4, 2019
@davenonymous
Copy link

  • Could you elaborate a bit on the Twilight Forest trees? Why were those necessary?
  • I do not want support for Plants, i.e. cactuses and shrooms, but I can remove those manually after I accepted the PR.
  • Looks good to me otherwise.

Thanks again.

@katubug
Copy link
Owner Author

katubug commented Jun 4, 2019

For whatever reason, the TF trees that I added were not showing as available in bonsai pots, according to JEI. I assumed you had either omitted them purposely or had just not gotten around to adding them. Although it's worth mentioning that they did show up under /bonsai listAlltrees.

The others, like the Twilight Oaks and the Rainbow Tree worked just fine out of the box, so I left those alone.

@katubug katubug marked this pull request as ready for review June 4, 2019 18:13
@katubug
Copy link
Owner Author

katubug commented Jun 4, 2019

Addendum: I think I may have figured out why they weren't working! It's a foolish mistake, unfortunately, lol. I had been left clicking the saplings in JEI instead of right clicking. Right clicking them in an environment without my scripts or configs has them show correctly that they're compatible with Bonsai Trees. Eep.

I'm not sure why some can be left-clicked and not others, but that was definitely my issue. Guess I'll just go ahead and delete those files, then, haha!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants