Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree Shapes for Plants defined in Types #2

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

katubug
Copy link
Owner

@katubug katubug commented Jun 4, 2019

Shapes for all the tree and plant types defined in "types.d."

Shapes for all the tree and plant types defined in "types.d"
@katubug katubug changed the title Add files via upload Tree Shapes for Plants defined in Types Jun 4, 2019
@davenonymous
Copy link

Hey, looks good, but two things:

  • Are the changes to the twilight forest trees necessary? What was the idea behind those?
  • Some of the Project Vibrant trees seem very large. Not sure how much of a performance impact those would have (one of the reasons why I've usually left out the big redwood trees from other mods etc).

@katubug
Copy link
Owner Author

katubug commented Jun 4, 2019

I didn't make any actual changes to the Twilight Trees, just generated models for them and, when they still didn't show up as compatible in JEI, created the types as well.

Personally, I haven't had any performance issues with them, but I haven't tested them out en masse, only a single tree of each type. I can build and generate some smaller models though, which trees did you want them for? I know Baobab is pretty big, which others?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants