Merge pull request #422 from kausaltech/fix/trend-line-width

Fix trend line not extending to the goal year
kausaltech · Oct 25, 2024 · 133da20 · 133da20
2 parents 7cf6e49 + 27ecf6b
commit 133da20
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/components/indicators/IndicatorVisualisation.js b/components/indicators/IndicatorVisualisation.js
@@ -310,8 +310,12 @@ const generateTrendTrace = (indicator, traces, goals, i18n) => {
 
     const highestDataYear = traces[0].y[traces[0].y.length - 1];
     const highestGoalYear = Math.max(
-      ...goals.map((goal) => goal.x[goal.x.length - 1])
+      ...goals.map((goal) => {
+        const goalDate = goal.x[goal.x.length - 1];
+        return goalDate ? new Date(goalDate).getFullYear() : NaN;
+      })
     );
+
     if (highestGoalYear && highestGoalYear > highestDataYear) {
       predictedTrace.x.push(highestGoalYear);
     }