Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncate long category names in category badges #164

Merged
merged 4 commits into from
Sep 25, 2023

Conversation

woodwoerk
Copy link
Collaborator

Asana 🎫

Now that we support category names up to 200 characters in length:

  • Limit category badges to two lines for a more approachable UI
  • Add category identifiers to badges for easier glanceability/ cross referencing
Screenshot 2023-09-20 at 18 21 48

Open thoughts (any preferences here @terotik?):

  • Should we also truncate long categories in breadcrumbs? → Leaning towards yes – breadcrumbs will be really cumbersome with multiple 150+ char crumbs
  • Should we also truncate long categories in card titles? → Leaning towards no

@terotik
Copy link
Contributor

terotik commented Sep 22, 2023

Agree on the leanings!

  • Should we also truncate long categories in breadcrumbs? → Leaning towards yes – breadcrumbs will be really cumbersome with multiple 150+ char crumbs
  • Should we also truncate long categories in card titles? → Leaning towards no

@terotik
Copy link
Contributor

terotik commented Sep 22, 2023

I think I merged in wrong order sorry 🥺 @woodwoerk - I guess better process would be for the PR creator handling the merge after approval

@woodwoerk
Copy link
Collaborator Author

I think I merged in wrong order sorry 🥺 @woodwoerk - I guess better process would be for the PR creator handling the merge after approval

😄 No worries! Yeah that's a good way to go, I'll fix those conflicts and merge this

@woodwoerk woodwoerk force-pushed the feat/clip-long-categories branch from 13660f5 to a88d84a Compare September 22, 2023 13:08
@woodwoerk woodwoerk force-pushed the feat/clip-long-categories branch from a88d84a to beb0964 Compare September 22, 2023 13:09
@woodwoerk woodwoerk merged commit 80f3fa7 into master Sep 25, 2023
1 check passed
@woodwoerk woodwoerk deleted the feat/clip-long-categories branch September 28, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants