Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support templateable category pages #167

Merged
merged 8 commits into from
Sep 28, 2023
Merged

Conversation

woodwoerk
Copy link
Collaborator

@woodwoerk woodwoerk commented Sep 25, 2023

Render category pages based on category type layout configuration. If a layout hasn't been defined, fall back to the old category page rendering.

Available to test in staging:

  1. Tampere:
    1.a. Example with custom hero, main and aside layout content
    1.b. Example with custom header content and main layout, no aside
  2. SCA:
    2.a. Example with aside links & contact information
    2.b. Example with no custom layout, fallback applied

Note: There are still some spacing issues/ inconsistencies to be fixed.

@woodwoerk woodwoerk force-pushed the feat/template-category-page branch from 5dd5950 to 9905ca6 Compare September 25, 2023 11:28
@woodwoerk woodwoerk changed the title Support templateable category page heroes Support templateable category pages Sep 26, 2023
@woodwoerk woodwoerk marked this pull request as ready for review September 26, 2023 15:28
Copy link
Contributor

@terotik terotik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (apart from the spacing issues) but ok to publish now if this is time sensitive and handle those spacings later

I know it's a challenge to use originally full page width streamfield blocks in containers :)

@woodwoerk woodwoerk merged commit ec9a08e into master Sep 28, 2023
2 checks passed
@woodwoerk woodwoerk deleted the feat/template-category-page branch September 28, 2023 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants