Added responsive styles to embeds #172
Conversation
lilia1891
commented
Sep 27, 2023
lilia1891
commented
- Individual embeds: added responsive styles to iframes according to the received CSS classes;
- RichText embeds: added styles for the received responsive object class.
|
One minor naming suggestion. Otherwise, looks good, but maybe @terotik should take a look at the actual CSS. |
components/common/RichText.tsx
Outdated
| @@ -52,6 +52,22 @@ type RichTextImageProps = { | |||
| }; | |||
| }; | |||
|
|
|||
| const RichTextStyles = styled.div` | |||
There was a problem hiding this comment.
Because these styled components are still components, I wouldn't name it as just --Styles, even thought styling is here the only reason for the component's existence. I would maybe call these StyledRichText or RichTextContainer or something like that. (I think we have used at least Styled* elsewhere.
There was a problem hiding this comment.
Changed. Thank you for a suggestion.
There was a problem hiding this comment.
Looks good to me thanks!
aspect-ratio css is fairly new (to me at least) so I'm slightly concerned about the browser support. Caniuse gives 89.98% global support.
It's mainly the slightly older versions and IE who lack support. We could consider this fallback if we get reports of embeds not working in some browsers.
Ok to relase from me
