Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement provider-specific sizing for embeds #178

Merged
merged 2 commits into from
Oct 3, 2023
Merged

Implement provider-specific sizing for embeds #178

merged 2 commits into from
Oct 3, 2023

Conversation

tituomin
Copy link
Contributor

@tituomin tituomin commented Oct 2, 2023

No description provided.

@tituomin tituomin requested review from terotik and woodwoerk October 2, 2023 14:06
woodwoerk
woodwoerk approved these changes Oct 3, 2023
View reviewed changes
Copy link
Collaborator

@woodwoerk woodwoerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Is this the end of the resizable embeds saga? 😁

components/common/StreamField.tsx Outdated Show resolved Hide resolved
@tituomin tituomin requested review from woodwoerk and removed request for terotik October 3, 2023 06:59
@tituomin tituomin merged commit 271321f into master Oct 3, 2023
1 check passed
@tituomin tituomin deleted the feature/provider-specific-embed-sizing branch October 3, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woodwoerk woodwoerk woodwoerk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tituomin @woodwoerk