Add icon support to category cards #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terotik
changed the title
tituomin
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handling category icons in category list cards
Prior the plan admin has had to incorporate the icon in the category image for it to be visible in the card. That has caused all sorts of scaling problems and questions. Here we prioritise showing category icon in the card if no image is set for category.
Test cases (in staging):
Wärmeversorgung: no category image - svg icon - category has color
Mobilität: no category image - svg icon - category has no color
Fotovoltaik: no category image - bitmap icon - category has no color
Netto-Null-Stadtverwaltung: no category image - bitmap icon - category has color
Übrige Themen: category image - bitmap icon - category has no color