Adapt to changes to IndicatorGroupBlock in backend #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bbliem Sorry I didn't make this clearer, but the frontend is already completed. PR here along with the other request and some type conversions: #197.
Could we schedule the frontend and backend to be deployed during off-peak hours? |
|
Sorry, you probably mentioned this and I forgot. Anyway it has hardly any work, so I'm going to close this PR. I added a shim so we can upgrade the backend without breaking the UI. No need for a coordinated deployment now. (But the backend needs to be deployed before the UI.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the frontend part of the changes in https://github.com/kausaltech/kausal-watch-private/pull/76. Unfortunately the schema changes due to the backend changes, so we cannot deploy the backend without breaking the frontend and vice versa. Perhaps we should add a shim, but that's always a PITA.