Accommodate multiple logos on custom bgcolor in footer #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terotik
force-pushed
the
feature/second-footer-colors
branch
from
a5a4794 to
ddec397
Compare
|
Sorry for the late review, but looks good ✅ I agree that the side effect is fine for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
** requires theme update **
https://github.com/kausaltech/kausal-themes/pull/7
Side effects:
If second footer contains statement AND otherLogos they are not adjacent anymore:
Needs more work to handle this edge case, but should be ok for now