Contact form feedback and email field settings #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bhavatu
force-pushed
the
feature/contact_form_feedback_field_optional
branch
from
87450f4 to
3e046a4
Compare
tituomin
approved these changes
Oct 21, 2024
components/common/FeedbackForm.js
Outdated
| if (Array.isArray(value)) { | ||
| return value.length === 0; | ||
| } | ||
| return value === '' || value === null || value === undefined; |
There was a problem hiding this comment.
Also, you can use value == null instead of value === null || value === undefined
Also, you should maybe move the null/undefined check first, then you can add the trim()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feedback forms comment field ("Feedback") and email field can now be hidden, optional or required based on settings from the backend.
Depending on backend: https://github.com/kausaltech/kausal-watch-private/pull/281