Highlight the late tasks in the Action Task List #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tituomin
approved these changes
Oct 29, 2024
components/actions/TaskList.js
Outdated
| </ListGroupItem> | ||
| )); | ||
| .map((item) => { | ||
| const isLate = !completed && new Date(item.dueAt) < new Date(); |
There was a problem hiding this comment.
Extract isLate into a function (see above)?
Also, just a curious peculiarity: new Date() is always in the browser's local timezone, but item.dueAt is in the plan's local timezone. I don't think we need to do anything about it though, because it always works as intended from the customer's own browsers. Only from the other side of the world it might sometimes be one day off but no big deal.
There was a problem hiding this comment.
Renamed to isTaskLate and extracted into a reusable function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UI improvement: Display late tasks as late in action task list - Asana https://app.asana.com/0/1205310117865974/1207617873637474/f
StatusBadgecomponent for visual consistency to mark the late tasks within theListGroupItem.ListGroupItemwhen a task is marked as late, using the background color from the StatusBadge/late.To do next: Add translations for the "Late" label via Weblate to support other languages.