Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix run manager bugs #141

Merged
merged 10 commits into from
Aug 30, 2024
Merged

Conversation

xuyuon
Copy link
Contributor

@xuyuon xuyuon commented Aug 30, 2024

Fixed a number of bugs:

  1. The likelihood now should also take sample_transform and likelihood_transform
  2. save_summary() no longer prints self.SNRs if the run is not an injection run.
  3. save_summary() will switch back to the original output method after completing the summary file printing.
  4. Fixed the issue where initialize_transforms() will drops the name in self.run.sample_transforms and run.likelihood_transforms

@xuyuon xuyuon requested a review from thomasckng August 30, 2024 01:52
@thomasckng
Copy link
Collaborator

thomasckng commented Aug 30, 2024

@xuyuon Feel free to merge it anytime

@xuyuon xuyuon merged commit ca9f906 into kazewong:run-manager Aug 30, 2024
2 of 4 checks passed
@xuyuon xuyuon deleted the fix-run-manager-bugs branch November 5, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants