Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update initial points sampling in maximize_likelihood #158

Closed
wants to merge 2 commits into from
Closed

Update initial points sampling in maximize_likelihood #158

wants to merge 2 commits into from

Conversation

thomasckng
Copy link
Collaborator

Used the same implementation as #152

@thomasckng thomasckng requested a review from kazewong September 17, 2024 00:52
kazewong
kazewong previously approved these changes Oct 13, 2024
View reviewed changes
kazewong
kazewong reviewed Oct 13, 2024
View reviewed changes
Copy link
Owner

@kazewong kazewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build has failed, please check if there is any error

@kazewong kazewong dismissed their stale review October 13, 2024 00:29

I approved this by mistake

@kazewong kazewong self-requested a review October 13, 2024 00:30
@kazewong
Copy link
Owner

I fixed this in #163

@kazewong kazewong closed this Oct 13, 2024
@thomasckng thomasckng deleted the fix-initial-sampling branch October 13, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazewong kazewong Awaiting requested review from kazewong

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomasckng @kazewong