Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change environment variables injection #184

Merged
merged 8 commits into from
Feb 22, 2024
Merged

Change environment variables injection #184

merged 8 commits into from
Feb 22, 2024

Conversation

LaChope
Copy link
Collaborator

@LaChope LaChope commented Feb 22, 2024 •
edited
Loading

Resolves #177, #178, #181 and #182.

FYI @shellyear

@LaChope LaChope requested a review from blcham February 22, 2024 12:36
This was linked to issues Feb 22, 2024
Investigate if rollup config is really needed in vite.config.js #178
Closed
Environment variables should be dynamically selected #181
Closed
Title should be dynamically changed at runtime #182
Closed
blcham
blcham approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@blcham blcham left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, solves the referenced issues but name of variables are different than agreed. See my comment. It can be implemented in separate ticket.

.env.development Outdated Show resolved Hide resolved
@LaChope LaChope merged commit d1df22e into main Feb 22, 2024
1 check passed
@LaChope LaChope deleted the change-environment-variables-injection branch February 22, 2024 15:48
@blcham
Copy link
Contributor

blcham commented Feb 22, 2024

Great job @LaChope !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blcham blcham blcham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@LaChope @blcham