Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added default gate type to created fault tree #366

Merged
merged 6 commits into from
Jun 7, 2024
Merged

Added default gate type to created fault tree #366

merged 6 commits into from
Jun 7, 2024

Conversation

LaChope
Copy link
Collaborator

@LaChope LaChope commented Jun 5, 2024

Resolves #346.

@LaChope LaChope requested a review from blcham June 5, 2024 08:10
blcham
blcham approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@blcham blcham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be merged, just check my comment

src/components/dialog/faultEvent/FaultEventCreation.schema.tsx Outdated Show resolved Hide resolved
@LaChope
Copy link
Collaborator Author

LaChope commented Jun 6, 2024

@blcham I am not merging yet because I am using this branch to also resolve #352.

@blcham
Copy link
Contributor

blcham commented Jun 7, 2024

@blcham I am not merging yet because I am using this branch to also resolve #352.

ok

@LaChope LaChope linked an issue Jun 7, 2024 that may be closed by this pull request
It is not possible to create new fault tree (internal server error) kbss-cvut/fta-fmea#96
Closed
@LaChope
Copy link
Collaborator Author

LaChope commented Jun 7, 2024

@blcham this is ready for review now

blcham
blcham approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@blcham blcham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I was not able to check the PR. It is too complicated to me (seems like a lot of reformating of code but was not able to identify which code does just reformating and which is actually doing some work)

src/components/dialog/faultEvent/FaultEventCreation.tsx Show resolved Hide resolved
@blcham blcham merged commit 9e20b4e into main Jun 7, 2024
1 check passed
@blcham blcham deleted the fix/tree-creation branch June 7, 2024 19:34
@LaChope LaChope mentioned this pull request Jun 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blcham blcham blcham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@LaChope @blcham