Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#439, #444, #409] - Fixes #501

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Conversation

@Kasmadei Kasmadei requested review from blcham and LaChope July 8, 2024 15:10
@Kasmadei Kasmadei changed the title [#439, #444, #474] - Fixes [#439, #444, #409] - Fixes Jul 8, 2024
Copy link
Contributor

@blcham blcham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although do not like that it is not separated in commits

Copy link
Collaborator

@LaChope LaChope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just see minor comment, LGTM

@Kasmadei
Copy link
Collaborator Author

Kasmadei commented Jul 8, 2024

@blcham updated

Copy link
Contributor

@blcham blcham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blcham blcham force-pushed the fixes-for-439-444-474 branch from 06b5a74 to 26bd38e Compare July 8, 2024 17:11
@blcham blcham merged commit d33163f into kbss-cvut:main Jul 8, 2024
1 check passed
@blcham blcham deleted the fixes-for-439-444-474 branch July 8, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants