Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clicking on apply layout now overrides persisted nodes #610

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Clicking on apply layout now overrides persisted nodes #610

merged 2 commits into from
Sep 30, 2024

Conversation

LaChope
Copy link
Collaborator

@LaChope LaChope commented Sep 26, 2024

Resolves #527 and #605

@LaChope LaChope requested a review from blcham September 26, 2024 12:18
@LaChope LaChope linked an issue Sep 26, 2024 that may be closed by this pull request
Layouted nodes should not be moved #605
Closed
@LaChope LaChope requested a review from kostobog September 26, 2024 12:18
blcham
blcham reviewed Sep 26, 2024
View reviewed changes
Copy link
Contributor

@blcham blcham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, waiting for @kostobog to approve

@LaChope LaChope requested a review from blcham September 27, 2024 12:46
@LaChope LaChope linked an issue Sep 30, 2024 that may be closed by this pull request
Nodes cannot persist when coordinates are double #611
Closed
@blcham blcham merged commit 81508f0 into main Sep 30, 2024
1 check passed
@blcham blcham deleted the improve-automatic-layout branch September 30, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kostobog kostobog Awaiting requested review from kostobog

@blcham blcham Awaiting requested review from blcham

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@LaChope @blcham